Add 2024 Thank You Banners #656
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abban
force-pushed
the
thank-you-2024
branch
4 times, most recently
from
55bd647 to
b19b2ac
Compare
Abban
force-pushed
the
thank-you-2024
branch
2 times, most recently
from
19c4dc9 to
1eb1d7e
Compare
|
use |
moiikana
force-pushed
the
thank-you-2024
branch
3 times, most recently
from
d9830af to
1ff4a11
Compare
Previous fix did not work correctly on Firefox Chrome *can* `calc(100ch-80px)`, it was the height that was interfering. Changed the breakpoint for displaying the fullpage banner centerered because it was too small to early Ticket: https://phabricator.wikimedia.org/T382313
Number of members displayed in the stats block is now a locale-aware number that can be changed globally without redeploying the banners. Added more requirements to cleanup document. Ticket: https://phabricator.wikimedia.org/T382313
Sperling-0
force-pushed
the
thank-you-2024
branch
from
cbf7562 to
062f934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.